fix: stop swallowing exceptions in ChannelManager and CollectionTOCUtil#1190
fix: stop swallowing exceptions in ChannelManager and CollectionTOCUtil#1190pallakartheekreddy wants to merge 1 commit intocloud-store-refactoringfrom
Conversation
Three exception catch blocks were silently discarding failures, making problems invisible at runtime: - ChannelManager.populateDefaultersForCreation: replaced System.out.println with TelemetryManager.error so category-fetch failures appear in logs. Intentional graceful-continue behaviour is preserved (defaults already applied via putIfAbsent before the try block). - CollectionTOCUtil.validateDIALCodes: returning an empty list on parse failure caused all DIAL codes to appear valid even when the response could not be read. Now logs the error and re-throws a typed ServerException so callers know validation failed. - CollectionTOCUtil.searchLinkedContents: returning an empty list on parse failure silently dropped linked-content results. Now logs the error and re-throws a typed ServerException so callers can handle the failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
SonarCloud Analysis Results 🔍Quality Gate Results for Services:Please review the analysis results for each service. Ensure all quality gates are passing before merging. |
2 participants
Three exception catch blocks were silently discarding failures, making problems invisible at runtime:
ChannelManager.populateDefaultersForCreation: replaced System.out.println with TelemetryManager.error so category-fetch failures appear in logs. Intentional graceful-continue behaviour is preserved (defaults already applied via putIfAbsent before the try block).
CollectionTOCUtil.validateDIALCodes: returning an empty list on parse failure caused all DIAL codes to appear valid even when the response could not be read. Now logs the error and re-throws a typed ServerException so callers know validation failed.
CollectionTOCUtil.searchLinkedContents: returning an empty list on parse failure silently dropped linked-content results. Now logs the error and re-throws a typed ServerException so callers can handle the failure.